Simplify CI detection - #50661
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
There was a problem hiding this comment.
Seems like this will make it more painful to run the CI lint rules locally but it also seems like no one cares.
| const minimist = require("minimist"); | ||
| const os = require("os"); | ||
|
|
||
| const ci = ["1", "true"].includes(process.env.CI); |
There was a problem hiding this comment.
This gets set by the workflow or something, right? It's not something we set elsewhere?
There was a problem hiding this comment.
Correct; GHA sets CI=1 or similar.
What do you mean? We don't have any rules that are CI specific anymore, so |
| task("lint", lint); | ||
| task("lint").description = "Runs eslint on the compiler and scripts sources."; | ||
| task("lint").flags = { | ||
| " --ci": "Runs eslint additional rules", |
There was a problem hiding this comment.
For posterity, there are no additional rules; all rules already run. Probably this is a leftover from tslint or something.
4 participants
Pulled out of #50597.